Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Comment and subscribe #4296

Closed
wants to merge 13 commits into from
Closed

[WIP]Comment and subscribe #4296

wants to merge 13 commits into from

Conversation

SidharthBansal
Copy link
Member

@SidharthBansal SidharthBansal commented Dec 13, 2018 •
edited
Loading

Fixes #4283
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@ghost ghost assigned SidharthBansal Dec 13, 2018
@ghost ghost added the in progress label Dec 13, 2018
@SidharthBansal SidharthBansal changed the title Subscribe multiple tags [WIP]Subscribe multiple tags Dec 13, 2018
@plotsbot
Copy link
Collaborator

plotsbot commented Dec 13, 2018 •
edited
Loading

1 Error
🚫 There was an error with Danger bot’s Junit parsing: undefined method `value’ for nil:NilClass
1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
3 Messages
📖 @SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Pull Request is marked as Work in Progress
📖 #<NoMethodError: undefined method `value’ for nil:NilClass>

Generated by 🚫 Danger

@SidharthBansal
Copy link
Member Author

Working on it. Not pushed anything till yet. Just opened a PR. Will be pushing soon.

@SidharthBansal SidharthBansal added this to the Tagging and topics milestone Dec 15, 2018
@SidharthBansal
Copy link
Member Author

Laptop write access working now. :-)

This was referenced Dec 17, 2018
Closed
Closed
Closed
@ghost ghost removed the in progress label Dec 24, 2018
@ghost ghost added the in progress label Dec 27, 2018
@SidharthBansal SidharthBansal changed the title [WIP]Subscribe multiple tags [WIP]Comment and subscribe Dec 27, 2018
@emilyashley emilyashley deleted the subscribe_multiple_tags branch January 15, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SidharthBansal SidharthBansal

Labels
in progress
Projects
None yet
Milestone
Tagging and topics
Development

Successfully merging this pull request may close these issues.
2 participants
@SidharthBansal @plotsbot